fix(model_selection): parallel config-label counter must not depend on show_progress#197
Merged
Merged
Conversation
…less of show_progress The Manager counter for 'config k/N' labels was gated on the outer show_progress flag, but the per-config fold bars are always shown (the objective wrapper hardcodes show_progress=True). The MultiTask pipeline calls spotoptim_search with show_progress=False, so real runs created no counter and the labels froze at 'config 1/N' again — the original bug, reintroduced for exactly the pipeline path. Gate the counter on parallel_eval only; regression test covers the show_progress=False + n_jobs=2 path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
🎉 This PR is included in version 5.1.1-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
Author
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field report (team4_submit, 2026-06-07 16:00 run):
config 1/10labels frozen again despite 5.1.0. Root cause: the Manager counter was gated on the outershow_progressflag, but the per-config fold bars are always shown (the objective wrapper hardcodesshow_progress=True). The MultiTask pipeline callsspotoptim_searchwithshow_progress=False(its default), so real pipeline runs created no counter and workers fell back to the frozenlen(all_params)+1label — the original bug, reintroduced for exactly the production path.Fix: gate the counter on
parallel_evalonly (+ explanatory comment). New regression test reproduces the report (show_progress=False,n_jobs=2) — fails on 5.1.0, passes here.Verification
🤖 Generated with Claude Code